Skip to content

check etag on both download branches#3534

Merged
sbiscigl merged 1 commit intomainfrom
transfer-manager-etag-get-object
Sep 8, 2025
Merged

check etag on both download branches#3534
sbiscigl merged 1 commit intomainfrom
transfer-manager-etag-get-object

Conversation

@sbiscigl
Copy link
Copy Markdown
Collaborator

@sbiscigl sbiscigl commented Sep 5, 2025

Description of changes:

#3375 added e-tag matching support for doing ranged gets, but this was only one half of the call path. If the size a of a object it small enough we will do a non ranged get. This adds that missing bit of logic.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl force-pushed the transfer-manager-etag-get-object branch 2 times, most recently from 0b0be86 to 73b3ab3 Compare September 5, 2025 20:34
@sbiscigl sbiscigl marked this pull request as ready for review September 8, 2025 13:19
@sbiscigl sbiscigl force-pushed the transfer-manager-etag-get-object branch from 73b3ab3 to f5112fd Compare September 8, 2025 13:58
@sbiscigl sbiscigl force-pushed the transfer-manager-etag-get-object branch from f5112fd to 9287423 Compare September 8, 2025 14:34
@sbiscigl sbiscigl merged commit 9a537a0 into main Sep 8, 2025
6 checks passed
@sbiscigl sbiscigl deleted the transfer-manager-etag-get-object branch September 8, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants